Skip to content

Use move for std::vector instead of copying in path functions #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Use move for std::vector instead of copying in path functions #1895

wants to merge 10 commits into from

Conversation

@bobtista
Copy link

@bobtista bobtista commented Nov 23, 2025

Refactors path-following functions to use move when transferring std::vector<Coord3D> ownership

Changes:

  • Updated aiFollowExitProductionPath and aiFollowPath inline functions to accept non-const vector pointers and use std::move
  • Modified AIStateMachine::setGoalPath to move the vector instead of copying
  • Updated privateFollowPath and doQuickExit signatures to support move semantics

Caball009
Caball009 reviewed Nov 24, 2025
View reviewed changes
@bobtista bobtista marked this pull request as ready for review November 25, 2025 17:58
xezon
xezon reviewed Nov 25, 2025
View reviewed changes
Copy link

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check that the passed vector is never used after it is consumed?

@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Performance Is a performance concern labels Nov 25, 2025
@bobtista
Copy link
Author

bobtista commented Nov 25, 2025

Did you check that the passed vector is never used after it is consumed?

Looking at call sites, they all pass local vectors (exitPath, path) that are not used after the function call. They go out of scope immediately, so this is safe, right?

@xezon
Copy link

xezon commented Nov 25, 2025

Yes, when the std::vector contents are not used anymore after they are now consumed by the functions then this is safe.

xezon
xezon reviewed Nov 25, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xezon xezon xezon left review comments

@Caball009 Caball009 Caball009 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Minor Severity: Minor < Major < Critical < Blocker Performance Is a performance concern

Projects

None yet

Milestone

Runtime performance fixes & optimizat...

Development

Successfully merging this pull request may close these issues.

Consider moving std::vector instead of copying the data

3 participants

@bobtista @xezon @Caball009